-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Configurable origin #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable origin #233
Conversation
|
I like the singleton approach but I dont agree with * by default as it makes Zeppelin vulnerable to the attacks. This is how I did it. I need to fix the merge. |
|
The reason support * and allowing * by default is, to keep the same behavior with the previous version. Current origin autodetect routine is not sufficient to cover many cases. I think until Zeppelin gets better autodetect routine that covers most cases automatically, we need to support * and make it default. Otherwise people will keep asking and keep having trouble with configuring origin. Later when it covers most cases, we can deprecate * and then remove it finally. Please consider this too. |
|
I do don't get me wrong. But in this case it's equivalent of the door in a house. You want people to come in and out easily but you don't want all people to do it and hence the lock. |
|
@djoelz I agree on improving security of Zeppelin. However, many users uses Zeppelin behind the firewall. For them, forcing manual configuration of origin is just one more barrier to make Zeppelin up and running. And until now, Zeppelin used to allow all by default. And people already build their infrastructure, deployment scripts with Zeppelin based on this behavior on docker, cloud services, etc. If default behavior is changing, all people need to change their stuff. that's what currently happening. I can see your point that it's worth to bother people take care of security. However, not making user experience trouble is also important. I'd like to see more smooth approach. |
|
@Leemoonsoo Ok that seems like a good compromise. The only thing I would like to add is a link in the property summary that references the jira and mentions that if you use * you are vulnerable to it. Do you want me to merge your changes with mine? Who makes the fix? |
|
@djoelz If you're okay, prefer to merge your patch. And that's good idea about mentioning risk of *. |
|
cool! I'm on it! |
|
@Leemoonsoo Done! take a look at #235 and close this one if you sign off. |
#205 #216 improved security of Zeppelin.
This patch lets user specify origin name(s) by configurable parameters. Also allowing wildcard (*).